Limit the maximum number of requests which can issued concurrently to the chain #3350
+119
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the chain Controlled via the `max_concurrency` setting in the chain configuration.
|
I should probably use a |
|
Let's switch to |
Comment on lines
+76
to
+77
| // If that number was specified as 0, then we use the maximum amount of concurrency, | ||
| // and effectively disable the limit. |
There was a problem hiding this comment.
Should this fact be mentioned in the config.toml for the max_concurrency parameter?
There was a problem hiding this comment.
Yes, good catch! Maybe with a warning that doing this may completely overload the node.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR targets #3341
Controlled via the
max_concurrencysetting in the chain configuration.